Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(editor): Enable gapcursor, allows to put cursor between images #5095

Merged
merged 3 commits into from Dec 6, 2023

Conversation

mejo-
Copy link
Member

@mejo- mejo- commented Dec 6, 2023

πŸ“ Summary

Enable gapcursor extension and remove workaround to add newlines between images when uploading more than one.

πŸ–ΌοΈ Screenshots

🏑 After
recording1

🏁 Checklist

  • Code is properly formatted (npm run lint / npm run stylelint / composer run cs:check)
  • Sign-off message is added to all commits

Signed-off-by: Jonas <jonas@freesources.org>
Signed-off-by: Jonas <jonas@freesources.org>
Fixes: #3427

Signed-off-by: Jonas <jonas@freesources.org>
@mejo- mejo- added this to the Nextcloud 29 milestone Dec 6, 2023
@mejo- mejo- added the ux label Dec 6, 2023
Copy link
Collaborator

@max-nextcloud max-nextcloud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❀️ Thanks for looking into this!

@max-nextcloud
Copy link
Collaborator

This might also address some aspects of #3111

Copy link
Member

@juliushaertl juliushaertl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

πŸš€

(I need those nice test images as well 😁 πŸ¦–)

@mejo-
Copy link
Member Author

mejo- commented Dec 6, 2023

This might also address some aspects of #3111

Unfortunately not yet. We might be able to configure the mentions node to allow gapcursor before it, but out of the box it's not possible.

@mejo-
Copy link
Member Author

mejo- commented Dec 6, 2023

(I need those nice test images as well 😁 πŸ¦–)

I love them πŸ¦• They're from https://prosemirror.net/examples/dino/

@mejo- mejo- merged commit c442ff8 into main Dec 6, 2023
33 of 36 checks passed
@mejo- mejo- deleted the feat/gapcursor branch December 6, 2023 12:38
@mejo-
Copy link
Member Author

mejo- commented Dec 6, 2023

/backport to stable28

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Inserting image into line of text will add line break two chars after
3 participants