[stable26] Preserve queue during reconnects #5214
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
max-nextcloud
commented
Jan 9, 2024
•
max-nextcloud
commented
- backports Preserve step queue during reconnect #5126 by backporting [stable27] preserve websocket provider queue during reconnects #5151
- fix(sync): preserve queue if sendRemainingSteps fails
- fix(sync): keep queue around during reconnects
- fix(sync): ensure queue stays the same array
- fix(sync): only clear queue after successful send
- fix(sync): clear old providers on reconnect
During a network disconnect Yjs-websocket notices missing awareness messages and closes the connection. In this case the remaining steps can also not be send out and the request fails. Preserve the queue so we can use it once the network is back up. Signed-off-by: Max <max@nextcloud.com>
When yjs does not receive awareness updates it will close and reopen the websocket. Keep the content of the queue, i.e. the outgoing steps so they can be send out once the connection is back. Signed-off-by: Max <max@nextcloud.com>
Change the content of `queue` with `queue.splice` rather than setting `queue` to another array. Signed-off-by: Max <max@nextcloud.com>
Also add a unit test for the websocket polyfill Signed-off-by: Max <max@nextcloud.com>
avoids the old provider leaking error events. Signed-off-by: Max <max@nextcloud.com>
3 flaky tests on run #12416 ↗︎
Details:
|
|||||||||||||||||||||||||||
| Test | Artifacts | |
|---|---|---|
| Sync > saves the actual file and document state |
Screenshots
|
|
| Sync > saves on close |
Screenshots
|
|
| Sync > passes the doc content from one session to the next |
Screenshots
|
|
Review all test suite changes for PR #5214 ↗︎
|
/compile |
mejo-
approved these changes
Jan 9, 2024
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
juliushaertl
approved these changes
Jan 9, 2024
juliushaertl
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.