Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable26] fix(Tables): require at least one cell in the header #5468

Merged
merged 2 commits into from Mar 12, 2024

Conversation

backportbot[bot]
Copy link

@backportbot backportbot bot commented Mar 12, 2024

Backport of #5467

Warning, This backport's changes differ from the original and might be incomplete ⚠️

Todo

  • Review and resolve any conflicts
  • Remove all the empty commits

Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.

Fixes #4793.

Signed-off-by: Max <max@nextcloud.com>
@backportbot backportbot bot added this to the Nextcloud 26.0.13 milestone Mar 12, 2024
@mejo- mejo- changed the title [stable26] [stable27] fix(Tables): require at least one cell in the header [stable26] fix(Tables): require at least one cell in the header Mar 12, 2024
@mejo- mejo- marked this pull request as ready for review March 12, 2024 20:03
@mejo-
Copy link
Member

mejo- commented Mar 12, 2024

/compile amend

Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
Copy link

cypress bot commented Mar 12, 2024

4 flaky tests on run #12487 ↗︎

0 149 2 0 Flakiness 4

Details:

[stable26] fix(Tables): require at least one cell in the header
Project: Text Commit: 9ce51e9904
Status: Passed Duration: 10:26 💡
Started: Mar 12, 2024 8:57 PM Ended: Mar 12, 2024 9:07 PM
Flakiness  sync.spec.js • 3 flaky tests

View Output

Test Artifacts
Sync > saves the actual file and document state Screenshots
Sync > saves on close Screenshots
Sync > passes the doc content from one session to the next Screenshots
Flakiness  api/SyncServiceProvider.spec.js • 1 flaky test

View Output

Test Artifacts
Sync service provider > recovers from a dropped message Screenshots

Review all test suite changes for PR #5468 ↗︎

@mejo- mejo- merged commit 467b6f8 into stable26 Mar 12, 2024
34 checks passed
@mejo- mejo- deleted the backport/5467/stable26 branch March 12, 2024 21:40
@Altahrim Altahrim mentioned this pull request Mar 21, 2024
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants