Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci(test): remove nextcloud/ocp before running acceptance tests #1413

Merged
merged 1 commit into from Jul 11, 2023
Merged

ci(test): remove nextcloud/ocp before running acceptance tests #1413

merged 1 commit into from Jul 11, 2023

Conversation

st3iny
Copy link
Member

@st3iny st3iny commented Jul 10, 2023

Fix #1410

This is an evil hack but I prefer actually running acceptance tests.

Ref #1338 (comment) for a proper solution

@st3iny
ci(test): remove nextcloud/ocp before running acceptance tests
63d0b5a 
Signed-off-by: Richard Steinmetz <richard@steinmetz.cloud>
@st3iny st3iny self-assigned this Jul 10, 2023
kesselb
kesselb approved these changes Jul 10, 2023
View reviewed changes
Copy link
Contributor

@kesselb kesselb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😎

I agree with Christoph, cleaner to only install the ocp package for the psalm workflow.

@st3iny st3iny merged commit 1fd3fa9 into master Jul 11, 2023
15 checks passed
@st3iny st3iny deleted the ci/test/remove-ocp branch July 11, 2023 05:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kesselb kesselb kesselb approved these changes

@ChristophWurst ChristophWurst Awaiting requested review from ChristophWurst

Assignees

@st3iny st3iny

Labels
3. to review
Projects
💌 📅 👥 Groupware team
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix acceptance tests
2 participants
@st3iny @kesselb