Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Build tests again master and stable and update to nc 13 #181

Closed
wants to merge 5 commits into from

Conversation

hanzei
Copy link

@hanzei hanzei commented Jul 17, 2017

  • Build against stable12 and master
  • Add support for nc 13
  • Fix UI tests

Fixes #179

@ChristophWurst
Copy link
Member

Unrelated to the changes here but acceptance tests fail with nc13

@ChristophWurst
Copy link
Member

Fix acceptance tests

Almost 😉

There was 1 error:

1) OCA\TwoFactorTOTP\Tests\Acceptance\TOTPAcceptenceTest::testEnableTOTP

Facebook\WebDriver\Exception\NoSuchElementException: no such element: Unable to locate element: {"method":"partial link text","selector":"src="/settings/img/personal.svg"}

  (Session info: chrome=59.0.3071.86)

  (Driver info: chromedriver=2.29.461591 (62ebf098771772160f391d75e589dc567915b233),platform=Windows NT 6.1.7601 SP1 x86_64)

/home/travis/build/nextcloud/core/apps/twofactor_totp/vendor/facebook/webdriver/lib/Exception/WebDriverException.php:102

/home/travis/build/nextcloud/core/apps/twofactor_totp/vendor/facebook/webdriver/lib/Remote/HttpCommandExecutor.php:321

/home/travis/build/nextcloud/core/apps/twofactor_totp/vendor/facebook/webdriver/lib/Remote/RemoteWebDriver.php:597

/home/travis/build/nextcloud/core/apps/twofactor_totp/vendor/facebook/webdriver/lib/Remote/RemoteWebDriver.php:190

/home/travis/build/nextcloud/core/apps/twofactor_totp/tests/Acceptance/TOTPAcceptanceTest.php:89

@hanzei hanzei changed the title Build tests again master and stable and update to nc 13 [WIP] Build tests again master and stable and update to nc 13 Jul 20, 2017
@hanzei
Copy link
Author

hanzei commented Jul 20, 2017

@ChristophWurst Is there a test server with runs the current master branch, which I can use to test stuff?

@ChristophWurst
Copy link
Member

@ChristophWurst Is there a test server with runs the current master branch, which I can use to test stuff?

You can easily set up a local Nextcloud installation based on the current master branch: https://docs.nextcloud.com/server/12/developer_manual/general/devenv.html

@ChristophWurst ChristophWurst self-assigned this Aug 22, 2017
@hanzei hanzei force-pushed the fix_tests branch 2 times, most recently from c669b0c to a8a686b Compare August 22, 2017 21:22
@hanzei
Copy link
Author

hanzei commented Aug 23, 2017

@ChristophWurst I set up a development environment and installed twofactor_totp. But there seems to be a bug which keeps me from working on this. I reported it here

@Varbin Varbin mentioned this pull request Nov 30, 2017
@ChristophWurst
Copy link
Member

@hanzei I've integrated most of your changes in other PRs. Thanks a lot!

@ChristophWurst ChristophWurst deleted the fix_tests branch December 12, 2017 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants