Fix display of challenge error #163
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChristophWurst
previously approved these changes
Apr 29, 2022
st3iny
force-pushed
the
enh/noid/fix-error-display
branch
from
99201c7
to
758c6e6
Compare
|
Pushed again to (hopefully) fix CI. |
Signed-off-by: Richard Steinmetz <richard@steinmetz.cloud>
st3iny
force-pushed
the
enh/noid/fix-error-display
branch
from
758c6e6
to
d7def3a
Compare
ChristophWurst
approved these changes
May 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses two things:
I removed the immediate redirect after an error occurred. Instead, the user can read the error and press retry manually.
The display of the error itself was fixed. Before, the placeholder
{msg}was not replaced because the message was passed as an object instead of a string.