-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use new types introduced in Nextcloud 21 and bump compatibility #173
Use new types introduced in Nextcloud 21 and bump compatibility #173
Conversation
Signed-off-by: Ole Morten <om@haaland.biz>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems to work fine with a new nextcloud 21 installation.
Thanks for the PR @hlnd CI is failing because of #159 (which is already out of date again) |
After checking the patch, I think it might not be the best idea to change an existing migration. On the other hand were the DBAL types removed with 21, and that migration couldn't possibly run anymore. But will this patch also allow to take care of clients, which have existing |
The migration will still be run for new migrations. Existing migration files have to be touched. |
I can verify that the app works as expected with Nextcloud 21. Would be nice if this PR could be merged and a new app release be published @violoncelloCH 😊 |
Signed-off-by: Jonas Sulzer <jonas@violoncello.ch>
thanks for the PR @hlnd ! |
Well done, It works as expected. |
Thank you all. The red enable untested app has now disappeared from the admin pannel > apps. |
Signed-off-by: Ole Morten om@haaland.biz
Fixes #165.
Changes proposed in this pull request: