Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use @NoSameSiteCookieRequired annotation #159

Merged
merged 1 commit into from
Sep 27, 2017
Merged

Conversation

rullzer
Copy link
Member

@rullzer rullzer commented Sep 26, 2017

This is in master (13) now with nextcloud/server#6630

Stable12 will just ignore this.

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
@codecov
Copy link

codecov bot commented Sep 26, 2017

Codecov Report

Merging #159 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #159   +/-   ##
=========================================
  Coverage     37.14%   37.14%           
  Complexity      128      128           
=========================================
  Files            10       10           
  Lines           525      525           
=========================================
  Hits            195      195           
  Misses          330      330
Impacted Files Coverage Δ Complexity Δ
lib/Controller/SAMLController.php 44.34% <ø> (ø) 32 <0> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 03c97a4...f05649f. Read the comment docs.

@rullzer rullzer merged commit 78b0b38 into master Sep 27, 2017
@rullzer rullzer deleted the samesiteannotation branch September 27, 2017 06:27
rullzer added a commit to nextcloud/server that referenced this pull request Sep 27, 2017
This is no longer required now that
nextcloud/user_saml#159 is in

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants