[stable-3.2] Fix login flow with SAML #464
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![backportbot-nextcloud[bot]](https://avatars.githubusercontent.com/in/21012?s=60&v=4){kind=small}
Because of the strict samesite cookies SAML fails with the login flow. Because the post that comes back is not transfering the proper cookies to use the same session. Hence the token in use gets lost etc. Now we store this all (encrypted) in a cookie. So that when we come back we can restore the proper session. FAQ: * Is it elegant? Nope! * Does it work? Yes! Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
backportbot-nextcloud
bot
requested review from
blizzz,
juliushaertl,
MorrisJobke,
nickvergessen and
rullzer
rullzer
approved these changes
Oct 5, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
backport of #463