Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Viewer also for public links #89

Closed
grenzverkehr opened this issue May 3, 2019 · 19 comments · Fixed by #408
Closed

Viewer also for public links #89

grenzverkehr opened this issue May 3, 2019 · 19 comments · Fixed by #408
Labels
1. to develop Accepted and waiting to be taken care of enhancement New feature or request

Comments

@grenzverkehr
Copy link

In public links the old gallery slideshow is used and not the new viewer. In the gallery slideshow no videos are supported. Would be great if the new viewer could also use for public links. PS: Thanks a lot for implementing the video support!

@skjnldsv skjnldsv added 1. to develop Accepted and waiting to be taken care of enhancement New feature or request labels May 4, 2019
@skjnldsv
Copy link
Member

skjnldsv commented May 4, 2019

Hello!!
Yes this is planned! :)

@grenzverkehr
Copy link
Author

That's good! Would it be possible to do it in 16.0.1? That would be great!

@skjnldsv
Copy link
Member

skjnldsv commented May 5, 2019

@grenzverkehr depending on the way we release features with this app, this is still undecided :)

@grenzverkehr
Copy link
Author

Is there a chance that in version 17 the Viewer can be used with public links? In the version 16.0.1, unfortunately, it is not yet.

@szaimen
Copy link
Contributor

szaimen commented Nov 7, 2019

@skjnldsv Is this also resolved since #271 is merged now? :)
This is one of the last critical missing features besides #15 imho.

@skjnldsv
Copy link
Member

skjnldsv commented Nov 8, 2019

No it is not :)
It will require specific fixes on the various apps that provide public pages to be compatible

@szaimen
Copy link
Contributor

szaimen commented Nov 8, 2019

Okay, then we have to wait 👍

@grenzverkehr
Copy link
Author

The situation has worsened with Nextcloud 18. There is now no preview at all for photos and videos in public links. The "gallery slideshow" does not work anymore, because "gallery" does not exist anymore and "viewer" can still not be used in public links :(

@skjnldsv
Copy link
Member

Photo issue is here: nextcloud/photos#128

@szaimen

This comment has been minimized.

@jospoortvliet
Copy link
Member

FYI, we are trying to fix this and other regressions asap. This was an oversight that even the testing during beta and rc didn't catch - sorry for that, lucky news is that you can get involved in testing to help avoid these issues next time!

See https://help.nextcloud.com/t/new-photo-app-in-nextcloud-18/69949/32 for a more complete response.

@grenzverkehr
Copy link
Author

Thanks a lot. It would be so great if it could also work for videos: #408

@skjnldsv
Copy link
Member

@grenzverkehr planned, this is why #408 is still a draft :)

@SimJoSt
Copy link

SimJoSt commented May 16, 2020

I have followed the issues surrounding public photo display including this one. We have been running 18.0.4 for some time and as the related merge request has been backported into that release, I should be able to use the slideshow on public links. However, this is not the case. Files still get downloaded when you click on them.
Is there anything else than using a version which contains this fix I need to take care of?
I feel like I'm missing something and don't want to reopen the issue without exploring potential errors on my setup first.

@Wikinaut
Copy link

Regression. Not working on my instances.

  • Nextcloud 18.0,4

@jospoortvliet
Copy link
Member

Pls file a new issue for that.

@schnickfunk
Copy link

This is still not working with NC 19:
A slideshow of images is not possible in shared links. As a registered user it works.
I shared the link "normal" and directly from the photo app. Neither works.

@szaimen
Copy link
Contributor

szaimen commented Jun 17, 2020

Does this help?
#500 (comment)

@schnickfunk
Copy link

schnickfunk commented Jun 17, 2020

Thanks, i just found it, too: nextcloud/photos#128 (comment)
That works for me. I don't understand why, but it's going...

schnick

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1. to develop Accepted and waiting to be taken care of enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants