Add support for tiff and heif #1166
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This still needs a preview provider that support this image formats (e.g. the off by default imaginary preview provider or the avif image provider). Signed-off-by: Carl Schwan <carl@carlschwan.eu>
CarlSchwan
added
3. to review
juliushaertl
approved these changes
Feb 24, 2022
|
We still have no way to know if the preview is enabled. So enabling this on viewer can lead to images being opened but failing to be displayed. Which is not the behaviour we want. Unless those formats are enabled by default and working out of the box in server :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This still needs a preview provider that supports these image formats enabled to have the viewer open the image (data-has-preview=true). This is provided by the off by default imaginary image previewer or possibly other image providers or OC\Preview\HEIC and OC\Preview\TIFF
Signed-off-by: Carl Schwan carl@carlschwan.eu