Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use the enabled previews config to register images and add tiff/heif support #1177

Merged
merged 2 commits into from
Mar 3, 2022
Merged

Use the enabled previews config to register images and add tiff/heif support #1177

merged 2 commits into from
Mar 3, 2022

Conversation

skjnldsv
Copy link
Member

@skjnldsv skjnldsv commented Mar 3, 2022 •
edited

Following
#1166 (comment)

Use case:

  1. Have HEIC disabled as a provider
  2. Open Files and try to open an HEIC file
  3. The viewer opens and cannot display the file

Now we directly ignore the registration and show a warning
image

Thoughts? We could theoretically also use that list to register all enabled mimes. But I'm not sure that's a good idea.
Something feels off

Closes #1166

@skjnldsv skjnldsv added enhancement New feature or request 3. to review Waiting for reviews labels Mar 3, 2022
@skjnldsv skjnldsv added this to the Nextcloud 24 milestone Mar 3, 2022
@skjnldsv skjnldsv changed the title Use the enabled previews config to register images Use the enabled previews config to register images and add tiff/heif support Mar 3, 2022
@skjnldsv skjnldsv added the file support request Request support for a new mime type label Mar 3, 2022
@skjnldsv skjnldsv changed the title Use the enabled previews config to register images and add tiff/heif support Use the enabled previews config to register images and add tiff/heif support Mar 3, 2022
@skjnldsv
Use the enabled previews config to register images
73c75db 
Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>
@skjnldsv
Copy link
Member Author

skjnldsv commented Mar 3, 2022

I also updated the lockfile that seemed to be having issues

CarlSchwan
CarlSchwan approved these changes Mar 3, 2022
View reviewed changes
Copy link
Member

@CarlSchwan CarlSchwan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

very nice solution :)

@skjnldsv
Copy link
Member Author

skjnldsv commented Mar 3, 2022 •
edited

Tests are failing because we change the sidebar on master and the actions are broken

EDIT: fixed sidebar tests

@skjnldsv
Fix sidebar test
166426b 
Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>
@skjnldsv skjnldsv added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Mar 3, 2022
@skjnldsv skjnldsv merged commit 011519f into master Mar 3, 2022
@skjnldsv skjnldsv deleted the feat/enabled-previews branch March 3, 2022 13:37
@skjnldsv skjnldsv mentioned this pull request Mar 29, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juliushaertl juliushaertl juliushaertl approved these changes

@CarlSchwan CarlSchwan CarlSchwan approved these changes

Assignees
No one assigned
Labels
4. to release Ready to be released and/or waiting for tests to finish enhancement New feature or request file support request Request support for a new mime type
Projects
None yet
Milestone
Nextcloud 24
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@skjnldsv @juliushaertl @CarlSchwan