fix: different cache path leads to cache miss #1695
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skjnldsv
force-pushed
the
feat/cache-test
branch
5 times, most recently
from
a66fc76
to
16a0f64
Compare
Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>
skjnldsv
changed the title
skjnldsv
commented
Jun 2, 2023
| with: | ||
| key: cypress-context-${{ github.run_id }} | ||
| path: /home/runner/work/viewer | ||
| path: ./ |
There was a problem hiding this comment.
This is the important part, we need to have the same path
skjnldsv
commented
Jun 2, 2023
Comment on lines
+72
to
+79
| - name: Set up node ${{ needs.init.outputs.nodeVersion }} | ||
| uses: actions/setup-node@64ed1c7eab4cce3362f8c340dee64e5eaeef8f7c # v3.6.0 | ||
| with: | ||
| cache: 'npm' | ||
| node-version: ${{ needs.init.outputs.nodeVersion }} | ||
|
|
||
| - name: Set up npm ${{ needs.init.outputs.npmVersion }} | ||
| run: npm i -g npm@"${{ needs.init.outputs.npmVersion }}" |
There was a problem hiding this comment.
This is also important, restoring the context does NOT restore the npm/node version 🙈
Meaning we've been running two different versions this whole time....
|
/backport to stable27 |
backportbot-nextcloud
bot
added
the
backport-request
juliushaertl
approved these changes
Jun 2, 2023
backportbot-nextcloud
bot
removed
the
backport-request
|
/backport to stable26 |
backportbot-nextcloud
bot
added
the
backport-request
|
/backport to stable25 |
|
The backport to stable26 failed. Please do this backport manually. # Switch to the target branch and update it
git checkout stable26
git pull origin stable26
# Create the new backport branch
git checkout -b fix/foo-stable26
# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts. Resolve them.
git cherry-pick abc123
# Push the cherry pick commit to the remote repository and open a pull request
git push origin fix/foo-stable26More info at https://docs.nextcloud.com/server/latest/developer_manual/getting_started/development_process.html#manual-backport |
|
The backport to stable25 failed. Please do this backport manually. # Switch to the target branch and update it
git checkout stable25
git pull origin stable25
# Create the new backport branch
git checkout -b fix/foo-stable25
# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts. Resolve them.
git cherry-pick abc123
# Push the cherry pick commit to the remote repository and open a pull request
git push origin fix/foo-stable25More info at https://docs.nextcloud.com/server/latest/developer_manual/getting_started/development_process.html#manual-backport |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@actions/cache, why are paths needed to compute version actions/toolkit#1433