Suggested fixes by ShellCheck #21
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
August 10, 2016 18:44
|
@ezraholm50 Can you please merge all your changes into this PR and I'll check it later today. Thanks! |
| @@ -3,13 +3,13 @@ | |||
| # Tech and Me, ©2016 - www.techandme.se | |||
|
|
|||
| SHUF=$(shuf -i 17-20 -n 1) | |||
| NEWMYSQLPASS=$(cat /dev/urandom | tr -dc "a-zA-Z0-9@#*=" | fold -w $SHUF | head -n 1) | |||
| NEWMYSQLPASS=$(cat < /dev/urandom | tr -dc "a-zA-Z0-9@#*=" | fold -w "$SHUF" | head -n 1) | |||
There was a problem hiding this comment.
Shoulnd't this be a '>' instead?
There was a problem hiding this comment.
Nope said it should be this way, thought it was strange to, but after changing the error went away so, we'll see.
|
This PR failed. ShellCheck is wrong, we are right. WIll close. |
Closed
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not tested cc @ezraholm50