-
Notifications
You must be signed in to change notification settings - Fork 187
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: role subscriptions #940
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- untested
- also needs updated versionadded
Co-Authored-By: teaishealthy <76410798+teaishealthy@users.noreply.github.com>
Co-Authored-By: teaishealthy <76410798+teaishealthy@users.noreply.github.com>
Co-authored-by: Oliver Wilkes <oliverwilkes2006@icloud.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Outside of the comments this seems fine to me. I havent found the DAPI docs for a couple things but it all makes sense to me
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
untested
Summary
#938
Checklist
task pyright
and fixed the relevant issues.