Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pipeline sharing support for alternative BitBucket Server #1297

Closed
piotr-faba-ardigen opened this issue Sep 4, 2019 · 3 comments
Closed

Pipeline sharing support for alternative BitBucket Server #1297

piotr-faba-ardigen opened this issue Sep 4, 2019 · 3 comments
Labels
help wanted
Milestone
v19.10.0

Comments

@piotr-faba-ardigen
Copy link

New feature

Nextflow currently supports in its pipelines sharing feature a product called BitBucket Cloud. This is different from a product called BitBucket Server (aka Stash in the past) which is BitBucket on premise at the moment. Graphical user interfaces look almost the same, but the API is different. Hence, the current implementation is not compatible with Bitbucket Server. The details about differences between those two products are discussed here.

Is there anything against adding this support?

Usage scenario

The feature will be useful to anyone attempting to use Nextflow sharing with BitBucket Server, which is typically the on-premise version of BitBucket.

Suggested implementation

Most probably all is needed it to create new class for the BitBucket Server provider: nextflow/scm/BitbucketServerRepositoryProvider.groovy, add tests similar to other providers, and add case bitbucket-server in nextflow/scm/RepositoryProvider.groovy.

Does this sound reasonable?
@pditommaso
Copy link
Member

A pull request is welcome

@piotr-faba-ardigen piotr-faba-ardigen mentioned this issue Sep 13, 2019
Closed
@piotr-faba-ardigen
Copy link
Author

A pull request is submitted: #1309

pditommaso added a commit that referenced this issue Oct 21, 2019
@pditommaso
Add BitBucket Server provider
6af6a90 
This commit adds the support for BitBucket Server Git
repository provider. Note BitBucket Server uses a different
API from BitBucket cloud provider.

This feature was contributed by Piotr Faba.

Merge #1309
Solve #1297
@pditommaso
Copy link
Member

Solved by 6af6a90.

@pditommaso pditommaso added this to the v19.10.0 milestone Oct 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
help wanted
Projects
None yet
Milestone
v19.10.0
Development

No branches or pull requests
2 participants
@pditommaso @piotr-faba-ardigen