Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kuberun executor does not support -entry pipeline parameter #2397

Closed
xhejtman opened this issue Oct 18, 2021 · 3 comments · Fixed by #2525
Closed

kuberun executor does not support -entry pipeline parameter #2397

xhejtman opened this issue Oct 18, 2021 · 3 comments · Fixed by #2525

Comments

@xhejtman
Copy link
Contributor

Some pipelines need to specify entry point via -entry cmdline parameter, e.g. scenic pipeline. This option is not supported/implemented in kuberun executor. As this is trival patch, please add it:

--- K8sDriverLauncher.groovy.orig	2021-09-30 13:17:44.595213768 +0200
+++ K8sDriverLauncher.groovy	2021-10-18 23:37:14.925102448 +0200
@@ -424,6 +424,7 @@
         addOption(result, cmd.&env )
         addOption(result, cmd.&process )
         addOption(result, cmd.&params )
+        addOption(result, cmd.&entryName )
 
         if( paramsFile ) {
             result << "-params-file $paramsFile"
@pditommaso
Copy link
Member

Feel free to send a pull request

@xhejtman
Copy link
Contributor Author

#2525

@abhi18av abhi18av linked a pull request Dec 26, 2021 that will close this issue
@abhi18av
Copy link
Member

Closing this as the linked PR is now merged - thanks for the contribution 🎉 !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants