Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not limit retries for re-sumbissions with maxErrors #46

Closed
manuelesimi opened this issue Jun 2, 2015 · 2 comments
Closed

Do not limit retries for re-sumbissions with maxErrors #46

manuelesimi opened this issue Jun 2, 2015 · 2 comments

Comments

@manuelesimi
Copy link
Collaborator

Currently, if maxErrors is set to a value lesser than maxRetries, only up to maxErrrors re-submissions are attempted for a process. From a user's perspective, this is a bit confusing, especially if only maxRetries is set and maxErrors is left to its default value (1). maxErrors should not limit the number of possible resubmissions.

From outside the box, I see to alternative ways to go:

  1. a conventional value (e.g. -1) for maxErrors that tells nextflow to ignore the errors limit. The risk with this option is that a process execution could go on forever with re-submissions. To avoid that, it should be allowed only when maxRetries is also set.
  2. when maxRetries is set, maxErrors is ignored, regardless its value. This could be seen as a sort of priority between them. The drawback is that the maximum number of re-submission is determined by maxRetries * number of execution instances.
@manuelesimi manuelesimi changed the title Do not limit retries for executions with maxErrors Do not limit retries for re-sumbissions with maxErrors Jun 2, 2015
@pditommaso
Copy link
Member

I think the first alternative is the best one. Indeed, maxErrors should be by default -1 so it does not check the errors upper limit.

Also maxRetries should by default 1, in this way the same task can be re-execute only one time, and it's coherent with the re-try semantic.

Then a user can set both maxErrors and maxRetries to higher values to tune the error strategy depending its requirements.

@pditommaso
Copy link
Member

Now it is possible to set maxErrors to -1 to ignore it. However the default has not changed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants