Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Timeline and execution reports may contain invalid memory values #999

Closed
pditommaso opened this issue Jan 15, 2019 · 3 comments
Closed

Timeline and execution reports may contain invalid memory values #999

pditommaso opened this issue Jan 15, 2019 · 3 comments
Milestone
v19.04.0

Comments

@pditommaso
Copy link
Member

The Memory unit string formatter uses a decimal separator symbol that's local depend. This can cause tricky if not invalid memory string values in the timeline and execution reports.
@pditommaso pditommaso mentioned this issue Jan 15, 2019
Closed
@phupe
Copy link
Contributor

phupe commented Jan 15, 2019 •
edited

As reported in #986, it seems to be a locale issue:

I have found the problem thanks to your comment! It is a locale issue.

My guess is that you should be able to reproduce the issue if you set export LANG=fr_FR.UTF-8 in the bash environment before launching nextflow.

The decimal point magically appears whether I set export LANG=C, export LANG=, or export LANG=en_US.UTF-8

pditommaso added a commit that referenced this issue Jan 15, 2019
@pditommaso
Fixed Invalid decimal separator in mem unit string #999
73977a9 
This commit makes sure that Mem unit to string conversion
uses a dot as decimal separator and avoid it depends on
local computer settings.

This commit removed an unnecessary comma string
replacement when formatting Memory units as for
change e6ec4c8.

Related #989 #999
@pditommaso pditommaso added this to the v19.04.0 milestone Jan 15, 2019
@pditommaso
Copy link
Member Author

Fixed.

@pditommaso
Copy link
Member Author

Included in version 19.02.0-edge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v19.04.0
Development

No branches or pull requests
2 participants
@pditommaso @phupe