Use base 2 to report memory values in the table-humanreadable similar… #1018
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ly to the memplot Signed-off-by: Philippe Hupé <philippe.hupe@curie.fr>
pditommaso
reviewed
Feb 6, 2019
| @@ -166,6 +166,7 @@ $(function() { | |||
| if (bytes == '-' || bytes == 0){ | |||
| return bytes; | |||
| } | |||
| bytes = norm_mem([bytes]); | |||
There was a problem hiding this comment.
Does this change work? bytes is expected to be a number instead norm_mem returns an array.
pditommaso
reviewed
Feb 6, 2019
| @@ -166,6 +166,7 @@ $(function() { | |||
| if (bytes == '-' || bytes == 0){ | |||
| return bytes; | |||
| } | |||
| bytes = norm_mem([bytes]); | |||
| // https://stackoverflow.com/a/14919494 | |||
| var thresh = 1000; | |||
There was a problem hiding this comment.
Also, using thresh = 1024 should not do the same instead of using norm_mem ?
…ve base 2 unit memory in the Tasks table (nextflow-io#1018) Signed-off-by: Philippe Hupé <philippe.hupe@curie.fr>
|
Using norm_mem surprinsingly worked out. This is very true: much better to set |
|
Excellent! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the memplot form the report, memory usage are plotted using a base 2 unit.
In the table-humanreadable from the report, the task table displays the memory using a base 10 unit.
The pull request harmonizes the memory unit such that base 2 unit is used in both cases.