Provide scm credentials when fetching information about remote branches. #1135
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
April 29, 2019 13:00
…r stream is not always returned which would trigger a NullPointerException masking the true error that occurred. Signed-off-by: Ólafur Haukur Flygenring <olafurh@wuxinextcode.com>
before fetching (fixes issue nextflow-io#1134). Signed-off-by: Ólafur Haukur Flygenring <olafurh@wuxinextcode.com>
pditommaso
approved these changes
Apr 30, 2019
|
Excellent. Thanks a lot for this patch. |
sivkovic
pushed a commit
to sivkovic/nextflow
that referenced
this pull request
Jun 6, 2019
…es (nextflow-io#1135) * Switched to safe navigation operator when getting an error message (Error stream is not always returned which would trigger an NPE masking the true error that occurred. * Provide credentials, if they exist, to the remote git repository before fetching (fixes issue nextflow-io#1134). Signed-off-by: Ólafur Haukur Flygenring <olafurh@wuxinextcode.com>
sivkovic
pushed a commit
to sivkovic/nextflow
that referenced
this pull request
Jun 6, 2019
…es (nextflow-io#1135) * Switched to safe navigation operator when getting an error message (Error stream is not always returned which would trigger an NPE masking the true error that occurred. * Provide credentials, if they exist, to the remote git repository before fetching (fixes issue nextflow-io#1134). Signed-off-by: Ólafur Haukur Flygenring <olafurh@wuxinextcode.com> Signed-off-by: Ivkovic <sinisa.ivkovic@gmail.com>
pditommaso
pushed a commit
that referenced
this pull request
Jul 27, 2019
…es (#1135) * Switched to safe navigation operator when getting an error message (Error stream is not always returned which would trigger an NPE masking the true error that occurred. * Provide credentials, if they exist, to the remote git repository before fetching (fixes issue #1134). Signed-off-by: Ólafur Haukur Flygenring <olafurh@wuxinextcode.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for issue #1134