Fix: "invalid pod status" when running scrips with the kubernetes executor. #1242
Conversation
…kubernetes api. Signed-off-by: Ólafur Haukur Flygenring <olafurh@wuxinextcode.com>
Signed-off-by: Ólafur Haukur Flygenring <olafurh@wuxinextcode.com>
…hrown. Signed-off-by: Ólafur Haukur Flygenring <olafurh@wuxinextcode.com>
| } | ||
| // undetermined status -- return an empty response | ||
| return Collections.emptyMap() | ||
| } | ||
|
|
||
| throw new K8sResponseException("K8s invalid pod status (missing container status)", resp) | ||
| throw new K8sResponseException("K8s Can't determine pod state from status returned by K8s API ", resp) | ||
| } |
There was a problem hiding this comment.
Frankly, I think the previous err message was a bit more informative.
There was a problem hiding this comment.
@pditommaso The previous message did not reflect why the Exception was being thrown anymore. The problem is not missing container status, but rather that K8s returned a set of phase and conditions that the code can not determine the pod state (end of function without any resolvement).
I can revert the change to the message, or insert a more informative message of your choice 😄 (I'm really bad at constructing error message btw 🙈)
There was a problem hiding this comment.
Fair enough, what about K8s undermined status conditions for pod $podName ?
There was a problem hiding this comment.
Fair enough, what about
K8s undermined status conditions for pod $podName?
Sounds good to me. Will update pull request.
Signed-off-by: Ólafur Haukur Flygenring <olafurh@wuxinextcode.com>
Signed-off-by: Ólafur Haukur Flygenring <olafurh@wuxinextcode.com>
|
Thanks for this contribution. |
Fix for issue: #1223
Signed-off-by: Ólafur Haukur Flygenring olafurh@wuxinextcode.com