Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explicitly check whether module path does not end with .nf #1254

Merged
merged 1 commit into from Aug 8, 2019

Conversation

rernst
Copy link
Contributor

@rernst rernst commented Aug 1, 2019

Having a module file with multiple dots in its name results in an error. For example:

Module file location:

ls -1 NextflowCommandLineTools/bwa/0.7.5a.nf
NextflowCommandLineTools/bwa/0.7.5a.nf

Nextflow script

include mem from 'NextflowCommandLineTools/bwa/0.7.5a'

Running nextflow

nextflow run test.nf
N E X T F L O W  ~  version 19.07.0
Launching `test.nf` [furious_poincare] - revision: c5443c2765
WARN: DSL 2 IS AN EXPERIMENTAL FEATURE UNDER DEVELOPMENT -- SYNTAX MAY CHANGE IN FUTURE RELEASE
No such file: Can't find a matching module file for include: NextflowCommandLineTools/bwa/0.7.5a

I suggest to explicitly check whether module path does not end with '.nf'.

Signed-off-by: Robert Ernst <r.f.ernst-3@umcutrecht.nl>
@pditommaso
Copy link
Member

Ouch, thanks for reporting this.

Copy link
Member

@pditommaso pditommaso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done!

@pditommaso pditommaso merged commit 8253608 into nextflow-io:master Aug 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants