Fix for feature 1647 that allows non gpu k8s accelerator resources. #1649
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pditommaso
reviewed
Jun 24, 2020
modules/nextflow/src/main/groovy/nextflow/k8s/model/PodSpecBuilder.groovy
Outdated
Show resolved
Hide resolved
added 2 commits
June 24, 2020 09:26
Signed-off-by: Mike Smoot <msmoot@illumina.com>
Signed-off-by: Mike Smoot <msmoot@illumina.com>
mes5k
force-pushed
the
fix_accelerator_type_1647
branch
from
28e6ba4
to
2da1ca1
Compare
pditommaso
reviewed
Jun 24, 2020
There was a problem hiding this comment.
Cool! Please sign-off the DCO requirement. https://github.com/nextflow-io/nextflow/blob/master/CONTRIBUTING.md#contributing-code-changes
|
DCO should now be signed off. At least the check looks like it's passing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #1647 for details.