Add automountServiceAccountToken option for k8s executor #2562
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some pipelines need to pass -entry parameter. Make it work with kuberun executor. Signed-off-by: Lukas Hejtmanek <xhejtman@ics.muni.cz> Signed-off-by: Lukas Hejtmanek <xhejtman@gmail.com>
Signed-off-by: Lukas Hejtmanek <xhejtman@gmail.com>
Signed-off-by: Lukas Hejtmanek <xhejtman@gmail.com>
Worker pods do not need to automount service account token usually. Without token, it starts faster and it is a bit more secure. Signed-off-by: Lukas Hejtmanek <xhejtman@gmail.com>
pditommaso
approved these changes
Jan 21, 2022
bentsherman
approved these changes
Jan 21, 2022
|
Merged. Thanks for this contribution! |
Closed
phue
pushed a commit
to phue/nextflow
that referenced
this pull request
Jan 25, 2022
…#2562) [ci fast] Signed-off-by: Lukas Hejtmanek <xhejtman@ics.muni.cz> Signed-off-by: Lukas Hejtmanek <xhejtman@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Worker pods do not need to automount service account token usually.
Without token, it starts faster and it is a bit more secure.
Moreover, if for some highly parallel tasks a large number of pods is spawned at once, there are races in mounting. Setting this option to false (not by default), mitigate this issue.