Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: improve error message #2658

Conversation

jorgeaguileraseqera
Copy link
Contributor

closes #2627

Signed-off-by: Jorge Aguilera jorge.aguilera@seqera.io

@jorgeaguileraseqera jorgeaguileraseqera force-pushed the 2627-incorrect-error-message-access-to-is-undefined-since-process-doesnt-declare-any-output branch from 9207207 to 12ae2fd Compare February 18, 2022 12:35
@jorgeaguileraseqera jorgeaguileraseqera force-pushed the 2627-incorrect-error-message-access-to-is-undefined-since-process-doesnt-declare-any-output branch from 12ae2fd to 7553591 Compare March 22, 2022 10:57
closes #2627

Signed-off-by: Jorge Aguilera <jorge.aguilera@seqera.io>
@jorgeaguileraseqera jorgeaguileraseqera force-pushed the 2627-incorrect-error-message-access-to-is-undefined-since-process-doesnt-declare-any-output branch from 7553591 to 0677e50 Compare April 11, 2022 07:41
@pditommaso
Copy link
Member

pditommaso commented Apr 23, 2022

Ok, nice this. But I've realised it can be made a bit more precise by checking if output==null. in that case means the process has not been invoked

return output = new ChannelOut(copyOuts)

…undefined-since-process-doesnt-declare-any-output
Signed-off-by: Paolo Di Tommaso <paolo.ditommaso@gmail.com>
@pditommaso pditommaso merged commit e6ef017 into master Apr 23, 2022
@pditommaso pditommaso deleted the 2627-incorrect-error-message-access-to-is-undefined-since-process-doesnt-declare-any-output branch April 23, 2022 10:24
@pditommaso pditommaso added this to the 22.04.0 milestone Apr 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incorrect error message "Access to .... is undefined since process doesn't declare any output"
2 participants