Add tolerations pod option #2763
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pditommaso
requested changes
Apr 5, 2022
|
I wanted to clean up some of the k8s-related files to make them easier to read, but I wasn't sure if they justified a separate PR, so I included them with this one. You can inspect the two commits separately to make the review easier. Or if you prefer I could make a separate "general k8s cleanup" PR. |
bentsherman
force-pushed
the
ben/tolerations-pod-option
branch
from
0093501
to
41a4227
Compare
Signed-off-by: Ben Sherman <bentshermann@gmail.com>
bentsherman
force-pushed
the
ben/tolerations-pod-option
branch
from
41a4227
to
6494619
Compare
|
Okay I moved the k8s cleanup to a separate draft PR for later. Now you should only see the feature-specific changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the
tolerationspod option, which allows a pod to "tolerate" certain node taints during scheduling. Can be useful for situations where a node is designated for a specific use case (special CPU type, belongs to certain user group, etc), so it will only be scheduled to users who specifically tolerate the taint.I also reorganized some of the pod-related classes to be more readable. I pushed two separate commits so that you can distinguish the toleration-specific changes from the general changes.