use a remote config in kuberun #2781
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Lehmann-Fabian <fabian.lehmann@informatik.hu-berlin.de>
bentsherman
requested changes
Apr 8, 2022
There was a problem hiding this comment.
Looks good to me overall. Just a few small things and then we'll be ready to merge:
- please address my comments below
- add the new options to the Nextflow kuberun docs
- confirm that you've tested this feature on your k8s cluster
| @@ -248,7 +248,7 @@ class K8sDriverLauncher { | |||
| .setProfile(cmd.profile) | |||
| .setCmdRun(cmd) | |||
|
|
|||
| if( !interactive && !pipelineName.startsWith('/') ) { | |||
| if( !interactive && !pipelineName.startsWith('/') && !cmd.remoteProfile && !cmd.runRemoteConfig ) { | |||
There was a problem hiding this comment.
Would just checking cmd.runRemoteConfig be sufficient here?
…ith config Signed-off-by: Lehmann-Fabian <fabian.lehmann@informatik.hu-berlin.de>
Signed-off-by: Lehmann-Fabian <fabian.lehmann@informatik.hu-berlin.de>
bentsherman
approved these changes
Apr 11, 2022
Lehmann-Fabian
force-pushed
the
remoteProfile
branch
2 times, most recently
from
7d9b10f
to
ed1be19
Compare
|
@bentsherman can you please start the checks manually? The CI Pipeline seems not to start automatically. |
|
@pditommaso Can you tell why the CI tests aren't running? I can't trigger them manually. It just says "Waiting for status to be reported", I don't know what that means. |
|
it may be related to this change 6e23e03. @jorgeaguileraseqera any clue? |
Lehmann-Fabian
added a commit
to Lehmann-Fabian/nextflow
that referenced
this pull request
Apr 14, 2022
The PR action is not started automatically: nextflow-io#2781 It seems to be related to nextflow-io@6e23e03
|
I think this PR should fix it: #2796 |
Lehmann-Fabian
added a commit
to Lehmann-Fabian/nextflow
that referenced
this pull request
Apr 14, 2022
The PR action is not started automatically: nextflow-io#2781 It seems to be related to nextflow-io@6e23e03 Signed-off-by: Lehmann-Fabian <fabian.lehmann@informatik.hu-berlin.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using kuberun with remote configs is not yet possible. Therefore, I added the option to use a config file only located in the cluster.