Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve transpose and groupTuple examples in the docs #3685

Merged
merged 6 commits into from
Mar 10, 2023
Merged

Improve transpose and groupTuple examples in the docs #3685

merged 6 commits into from
Mar 10, 2023

Conversation

mribeirodantas
Copy link
Member

  • Add a real example to the groupTuple operator [ci skip]
  • Add a real example to the transpose operator [ci skip]

llewellyn-sl and others added 3 commits February 24, 2023 15:55
@llewellyn-sl
Small fixes to params-file example, grammar fixes (nextflow-io#3682) …
98103ab 
…[ci skip]

Signed-off-by: Llewellyn vd Berg <113503285+llewellyn-sl@users.noreply.github.com>
@mribeirodantas
Add a real example to the groupTuple operator [ci skip]
aff1b0a 
Signed-off-by: Marcel Ribeiro-Dantas <mribeirodantas@seqera.io>
@mribeirodantas
Add a real example to the transpose operator [ci skip]
55bc976 
Signed-off-by: Marcel Ribeiro-Dantas <mribeirodantas@seqera.io>
@bentsherman
Copy link
Member

On second thought, I think it would be better to not use SRA IDs and paths, it feels like too much unnecessary context.

I think you should leave the groupTuple example unchanged, and use the reverse of it for transpose:

    Channel
        .of( [1, ['A', 'B', 'C']], [2, ['C', 'A']], [3, ['B', 'D']] )
        .transpose()
        .view()

    [1, A]
    [1, B]
    [2, C]
    [3, B]
    [1, C]
    [2, A]
    [3, D]

@mribeirodantas
Copy link
Member Author

Ok! 😉

@mribeirodantas mribeirodantas force-pushed the improve-transpose_grouptuple-example branch from 3f7f45c to 99d1672 Compare February 27, 2023 18:49
@mribeirodantas
Copy link
Member Author

LGTM?

pditommaso
pditommaso approved these changes Mar 10, 2023
View reviewed changes
Copy link
Member

@pditommaso pditommaso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice

@pditommaso pditommaso merged commit 7870dfc into nextflow-io:master Mar 10, 2023
abhi18av pushed a commit to abhi18av/nextflow that referenced this pull request Oct 28, 2023
@mribeirodantas @llewellyn-sl @abhi18av
Improve transpose and groupTuple examples in the docs (nextflow-io#3685…
e442127 
…) [ci skip]


Signed-off-by: Llewellyn vd Berg <113503285+llewellyn-sl@users.noreply.github.com>
Signed-off-by: Marcel Ribeiro-Dantas <mribeirodantas@seqera.io>
Co-authored-by: Llewellyn vd Berg <113503285+llewellyn-sl@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pditommaso pditommaso pditommaso approved these changes

@bentsherman bentsherman bentsherman approved these changes

Assignees
No one assigned
Labels
docs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@mribeirodantas @bentsherman @pditommaso @llewellyn-sl