Kuberun: add plugins to config #3766
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Lehmann_Fabian <fabian.lehmann@informatik.hu-berlin.de>
|
I feel a test is missing 😄 |
Signed-off-by: Lehmann_Fabian <fabian.lehmann@informatik.hu-berlin.de>
|
Had the same feeling... |
pditommaso
approved these changes
Mar 16, 2023
|
|
|
The problem seems not to be related to me, but to the changes in this file: https://github.com/nextflow-io/hello/blob/master/nextflow.config |
|
Not sure, it looks the test is failing is this |
|
This test reads the config from here: https://github.com/nextflow-io/hello if I see correctly. |
|
You are right. I've reverted it |
|
Are you able to trigger tests again? https://github.com/Lehmann-Fabian/nextflow/actions/runs/4437679938 |
Signed-off-by: Lehmann_Fabian <fabian.lehmann@informatik.hu-berlin.de>
|
Thank you, seems to fix it :) |
pditommaso
approved these changes
Mar 16, 2023
abhi18av
pushed a commit
to abhi18av/nextflow
that referenced
this pull request
Oct 28, 2023
Signed-off-by: Lehmann_Fabian <fabian.lehmann@informatik.hu-berlin.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using
kuberunwith-plugins xydoes not yet hand this over to the head-pod. This is implemented in this PR. It would be nice to have this, especially for CWS.