Set scratch default to false when using Fusion #4675
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ben Sherman <bentshermann@gmail.com>
✅ Deploy Preview for nextflow-docs-staging canceled.
|
|
Agreed |
nschan
pushed a commit
to nschan/nextflow
that referenced
this pull request
Feb 6, 2024
Signed-off-by: Ben Sherman <bentshermann@gmail.com> Signed-off-by: Niklas Schandry <niklas@bio.lmu.de>
nschan
pushed a commit
to nschan/nextflow
that referenced
this pull request
Feb 6, 2024
Signed-off-by: Ben Sherman <bentshermann@gmail.com> Signed-off-by: Niklas Schandry <niklas@bio.lmu.de>
nschan
pushed a commit
to nschan/nextflow
that referenced
this pull request
Feb 12, 2024
Signed-off-by: Ben Sherman <bentshermann@gmail.com> Signed-off-by: Niklas Schandry <niklas@bio.lmu.de>
nschan
pushed a commit
to nschan/nextflow
that referenced
this pull request
Feb 12, 2024
Signed-off-by: Ben Sherman <bentshermann@gmail.com> Signed-off-by: Niklas Schandry <niklas@bio.lmu.de>
nschan
pushed a commit
to nschan/nextflow
that referenced
this pull request
Apr 3, 2024
Signed-off-by: Ben Sherman <bentshermann@gmail.com> Signed-off-by: Niklas Schandry <niklas@bio.lmu.de>
nschan
pushed a commit
to nschan/nextflow
that referenced
this pull request
Apr 3, 2024
Signed-off-by: Ben Sherman <bentshermann@gmail.com> Signed-off-by: Niklas Schandry <niklas@bio.lmu.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I spoke to Jordi and found that we originally defaulted scratch to true with Fusion at a time when Fusion was only staging input data. But now that Fusion handles both inputs and outputs staging, it makes no sense to ever use scratch=true with Fusion because it eliminates the performance benefit of Fusion. I think we can safely set the default to false now.