nf-wave WaveClient: fix for s5cmdConfigUrl #4707
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Dr Marco Claudio De La Pierre <marco.delapierre@gmail.com>
✅ Deploy Preview for nextflow-docs-staging canceled.
|
Signed-off-by: Paolo Di Tommaso <paolo.ditommaso@gmail.com>
Signed-off-by: Paolo Di Tommaso <paolo.ditommaso@gmail.com>
|
Well spotted. Added the support for "magic" type conversion and related tests |
nschan
pushed a commit
to nschan/nextflow
that referenced
this pull request
Feb 6, 2024
Signed-off-by: Dr Marco Claudio De La Pierre <marco.delapierre@gmail.com> Signed-off-by: Paolo Di Tommaso <paolo.ditommaso@gmail.com> Co-authored-by: Paolo Di Tommaso <paolo.ditommaso@gmail.com> Signed-off-by: Niklas Schandry <niklas@bio.lmu.de>
nschan
pushed a commit
to nschan/nextflow
that referenced
this pull request
Feb 6, 2024
Signed-off-by: Dr Marco Claudio De La Pierre <marco.delapierre@gmail.com> Signed-off-by: Paolo Di Tommaso <paolo.ditommaso@gmail.com> Co-authored-by: Paolo Di Tommaso <paolo.ditommaso@gmail.com> Signed-off-by: Niklas Schandry <niklas@bio.lmu.de>
nschan
pushed a commit
to nschan/nextflow
that referenced
this pull request
Feb 6, 2024
Signed-off-by: Dr Marco Claudio De La Pierre <marco.delapierre@gmail.com> Signed-off-by: Paolo Di Tommaso <paolo.ditommaso@gmail.com> Co-authored-by: Paolo Di Tommaso <paolo.ditommaso@gmail.com> Signed-off-by: Niklas Schandry <niklas@bio.lmu.de>
nschan
pushed a commit
to nschan/nextflow
that referenced
this pull request
Feb 12, 2024
Signed-off-by: Dr Marco Claudio De La Pierre <marco.delapierre@gmail.com> Signed-off-by: Paolo Di Tommaso <paolo.ditommaso@gmail.com> Co-authored-by: Paolo Di Tommaso <paolo.ditommaso@gmail.com> Signed-off-by: Niklas Schandry <niklas@bio.lmu.de>
nschan
pushed a commit
to nschan/nextflow
that referenced
this pull request
Feb 12, 2024
Signed-off-by: Dr Marco Claudio De La Pierre <marco.delapierre@gmail.com> Signed-off-by: Paolo Di Tommaso <paolo.ditommaso@gmail.com> Co-authored-by: Paolo Di Tommaso <paolo.ditommaso@gmail.com> Signed-off-by: Niklas Schandry <niklas@bio.lmu.de>
nschan
pushed a commit
to nschan/nextflow
that referenced
this pull request
Apr 3, 2024
Signed-off-by: Dr Marco Claudio De La Pierre <marco.delapierre@gmail.com> Signed-off-by: Paolo Di Tommaso <paolo.ditommaso@gmail.com> Co-authored-by: Paolo Di Tommaso <paolo.ditommaso@gmail.com> Signed-off-by: Niklas Schandry <niklas@bio.lmu.de>
nschan
pushed a commit
to nschan/nextflow
that referenced
this pull request
Apr 3, 2024
Signed-off-by: Dr Marco Claudio De La Pierre <marco.delapierre@gmail.com> Signed-off-by: Paolo Di Tommaso <paolo.ditommaso@gmail.com> Co-authored-by: Paolo Di Tommaso <paolo.ditommaso@gmail.com> Signed-off-by: Niklas Schandry <niklas@bio.lmu.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a small fix in WaveClient, to better handle
s5cmdConfigUrl.This is spun out of #4701, and comes from original Paolo's PR #4554.
internally renames
dockerArchtodockerPlat, for better jargon consistency in the codebase and docs. This variable specifies the platform to build containers via Wave, ie X86 or ARM.