Always emit publish event for symlinks on resume #4790
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ben Sherman <bentshermann@gmail.com>
✅ Deploy Preview for nextflow-docs-staging canceled.
|
|
Please add a comment making clear that the intent is to call the |
bentsherman
commented
Mar 5, 2024
….groovy Signed-off-by: Ben Sherman <bentshermann@gmail.com>
Signed-off-by: Paolo Di Tommaso <paolo.ditommaso@gmail.com>
nschan
pushed a commit
to nschan/nextflow
that referenced
this pull request
Apr 3, 2024
Signed-off-by: Ben Sherman <bentshermann@gmail.com> Signed-off-by: Niklas Schandry <niklas@bio.lmu.de>
nschan
pushed a commit
to nschan/nextflow
that referenced
this pull request
Apr 3, 2024
Signed-off-by: Ben Sherman <bentshermann@gmail.com> Signed-off-by: Niklas Schandry <niklas@bio.lmu.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close nextflow-io/nf-prov#22
When publishing a symlink for a cached task, the publish event is normally skipped because the source and target paths are the same "real path". This PR adjusts the logic to ensure that the publish event is still emitted.
Symlink is the default publish mode, and nf-prov depends on publish events to generate the provenance manifest, so this is causing some confusing behavior for new users of nf-prov.
This fix was tested with Rob's minimal example in the linked issue and works.