Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

4446 ignore then fail strategy v3 #5071

Merged

Conversation

pditommaso
Copy link
Member

This PR implements the fail on ignore by using by setting the option nextflow.enable.failOnIgnore in the nextflow config file.

Signed-off-by: Paolo Di Tommaso <paolo.ditommaso@gmail.com>
Signed-off-by: Paolo Di Tommaso <paolo.ditommaso@gmail.com>
@pditommaso pditommaso requested a review from a team as a code owner June 17, 2024 11:23
@pditommaso pditommaso changed the base branch from master to 4446-ignore-then-fail-strategy June 17, 2024 11:24
Copy link

netlify bot commented Jun 17, 2024

Deploy Preview for nextflow-docs-staging ready!

Name Link
🔨 Latest commit 65e3eb2
🔍 Latest deploy log https://app.netlify.com/sites/nextflow-docs-staging/deploys/66701cca7fc5a700082a8492
😎 Deploy Preview https://deploy-preview-5071--nextflow-docs-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Signed-off-by: Paolo Di Tommaso <paolo.ditommaso@gmail.com>
Signed-off-by: Paolo Di Tommaso <paolo.ditommaso@gmail.com>
Signed-off-by: Paolo Di Tommaso <paolo.ditommaso@gmail.com>
@bentsherman
Copy link
Member

I would suggest exposing it as nextflow.failOnIgnore so as to not confuse it with feature flags. Long term I don't think we should allow feature flags in the config because they are inherent to the pipeline code.

@bentsherman
Copy link
Member

In other words:

  • nextflow config scope is used for runtime options and is only relevant in the config file
  • feature flags are used for language options and are only relevant in the script

@pditommaso
Copy link
Member Author

That was the first option, but then I realised it's not a feature flag but more a workflow (error handling) behaviour, and as such reported in the workflow metadata

Signed-off-by: Paolo Di Tommaso <paolo.ditommaso@gmail.com>
@pditommaso
Copy link
Member Author

Let's go

@pditommaso pditommaso merged commit 849fe7e into 4446-ignore-then-fail-strategy Jun 17, 2024
17 checks passed
@pditommaso pditommaso deleted the 4446-ignore-then-fail-strategy-v3 branch June 17, 2024 18:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Defer error exit status to end of pipeline run
2 participants