provide schema path through the options map in validateParameters() #108

mirpedrol · 2023-10-11T09:46:37Z

All optional parameters are not provided though a map:
validateParameters(parameters_schema: 'my_params.json')

The same modification was also made for paramsSummaryMap()

⚠️ This will break pipelines who were previously providing a path using the schemaFilename argument validateParameters(schemaFilename = 'my_params.json')

nvnieuwk

LGTM! A necessary evil IMO

ewels

I imagine that this needs some docs updates :)

ewels

LGTM 👍🏻

docs/parameters/validation.md

mirpedrol added 2 commits October 11, 2023 11:38

add new test and try adding a second validateParameters function

b147378

add the argument for the schema in the options map

2a6e4c4

mirpedrol changed the title ~~add new test and try adding a second validateParameters function~~ provide schema path through the options map in validateParameters() Oct 11, 2023

mirpedrol requested review from ewels, mashehu and nvnieuwk October 11, 2023 14:35

mirpedrol marked this pull request as ready for review October 11, 2023 14:37

nvnieuwk approved these changes Oct 11, 2023

View reviewed changes

ewels suggested changes Oct 11, 2023

View reviewed changes

mirpedrol added 2 commits October 11, 2023 20:12

update docs

7c93e74

add test cleanup to remove remaining file

4a205b0

ewels approved these changes Oct 11, 2023

View reviewed changes

docs/parameters/validation.md Outdated Show resolved Hide resolved

argumentS

d3d6b55

mirpedrol merged commit 3f10d18 into nextflow-io:master Oct 12, 2023
3 checks passed

mirpedrol deleted the validateparameters-args branch October 12, 2023 06:16

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

provide schema path through the options map in validateParameters() #108

provide schema path through the options map in validateParameters() #108

mirpedrol commented Oct 11, 2023 •

edited

Loading

nvnieuwk left a comment

ewels left a comment

ewels left a comment

provide schema path through the options map in validateParameters() #108

provide schema path through the options map in validateParameters() #108

Conversation

mirpedrol commented Oct 11, 2023 • edited Loading

nvnieuwk left a comment

Choose a reason for hiding this comment

ewels left a comment

Choose a reason for hiding this comment

ewels left a comment

Choose a reason for hiding this comment

mirpedrol commented Oct 11, 2023 •

edited

Loading