Improve samplesheet typecasting #113
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mirpedrol
approved these changes
Oct 16, 2023
| log.debug("Could not convert ${input} to a float. Trying to convert to a double.") | ||
| } | ||
|
|
||
| def double result = input as double |
There was a problem hiding this comment.
Should we catch an error here too? And maybe throw a more explanatory message saying that the input is not a value. Although this will in theory be detected by the validation before the channel conversion.
There was a problem hiding this comment.
Yeah that was my reasoning too, the values should be compatible when they are validated so they shouldn't really fail
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #112
=> Also adds the
nulltype to be a bit closer to full support of all types.I'll handle
arrayin the hackathon :p