Skip to content
This repository has been archived by the owner on Aug 20, 2024. It is now read-only.

Allow quoted fields for csv files in .fromSamplesheet() #63

Merged
merged 3 commits into from
Jun 30, 2023
Merged

Allow quoted fields for csv files in .fromSamplesheet() #63

merged 3 commits into from
Jun 30, 2023

Conversation

koenbossers
Copy link
Contributor

fixes #62

@koenbossers
Copy link
Contributor Author

koenbossers commented Jun 29, 2023 •
edited

I do not know how to write tests for this feature (or actually in Groovy at all 😄 ), so it is probably necessary to add a specific test to the current test suite

@koenbossers
Copy link
Contributor Author

Ready for review!

nvnieuwk
nvnieuwk approved these changes Jun 30, 2023
View reviewed changes
Copy link
Collaborator

@nvnieuwk nvnieuwk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for the PR!

@koenbossers
Copy link
Contributor Author

Thanks! I am not allowed to merge, so feel free to do so

@nvnieuwk nvnieuwk merged commit 182c19a into nextflow-io:master Jun 30, 2023
3 checks passed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@nvnieuwk nvnieuwk nvnieuwk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Feature request: allow quotes strings containing commas in .fromSamplesheet() for .csv files
2 participants
@koenbossers @nvnieuwk