Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix error when a parameter is not present in the schema and evaluates to false #89

Merged
merged 3 commits into from
Sep 15, 2023
Merged

fix error when a parameter is not present in the schema and evaluates to false #89

merged 3 commits into from
Sep 15, 2023

Conversation

mirpedrol
Copy link
Collaborator

Close #48 and #84

Use the params map to retrieve the value of the specified param instead of paramsJson which does not contain parameters evaluating to false.

nvnieuwk
nvnieuwk approved these changes Sep 6, 2023
View reviewed changes
Copy link
Collaborator

@nvnieuwk nvnieuwk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@ewels ewels merged commit 10968ea into nextflow-io:master Sep 15, 2023
3 checks passed
@ewels ewels mentioned this pull request Sep 15, 2023
Closed
@mirpedrol mirpedrol deleted the empty-params branch September 18, 2023 11:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nvnieuwk nvnieuwk nvnieuwk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Unexpected error when a parameter isn't in the schema
3 participants
@mirpedrol @nvnieuwk @ewels