Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #336 baseDir -> projectDir, from -> of #337

Merged
merged 4 commits into from
May 27, 2024
Merged

Conversation

mribeirodantas
Copy link
Member

Signed-off-by: Marcel Ribeiro-Dantas mribeirodantas@seqera.io

Signed-off-by: Marcel Ribeiro-Dantas <mribeirodantas@seqera.io>
Copy link

netlify bot commented May 21, 2024

Deploy Preview for nextflow-training ready!

Name Link
🔨 Latest commit 45ec07c
🔍 Latest deploy log https://app.netlify.com/sites/nextflow-training/deploys/66551b632f3c3400081a8086
😎 Deploy Preview https://deploy-preview-337--nextflow-training.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Collaborator

@christopher-hakkaart christopher-hakkaart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All of this looks good to me @mribeirodantas. Small issue with Troubleshoot exercise 6, which actually troubleshoot the error with baseDir. I've suggested reversions for now until we rethink what to do. There might be wider changes to the material but I don't want to hold this up.

docs/troubleshoot/06_exercise.md Outdated Show resolved Hide resolved
docs/troubleshoot/06_exercise.md Outdated Show resolved Hide resolved
docs/troubleshoot/06_exercise.md Outdated Show resolved Hide resolved
docs/troubleshoot/06_exercise.md Outdated Show resolved Hide resolved
docs/troubleshoot/06_exercise.md Outdated Show resolved Hide resolved
troubleshoot/exercise6/hello-gatk.nf Outdated Show resolved Hide resolved
troubleshoot/exercise6/hello-gatk.nf Outdated Show resolved Hide resolved
troubleshoot/exercise6/hello-gatk.nf Outdated Show resolved Hide resolved
troubleshoot/exercise6/hello-gatk.nf Outdated Show resolved Hide resolved
troubleshoot/exercise6/hello-gatk.nf Outdated Show resolved Hide resolved
mribeirodantas and others added 3 commits May 27, 2024 20:45
Co-authored-by: Christopher Hakkaart <chris.hakkaart@seqera.io>
Co-authored-by: Christopher Hakkaart <chris.hakkaart@seqera.io>
Co-authored-by: Christopher Hakkaart <chris.hakkaart@seqera.io>
@mribeirodantas mribeirodantas merged commit ffd71fa into master May 27, 2024
8 checks passed
@mribeirodantas mribeirodantas deleted the update-baseDir branch May 27, 2024 23:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants