Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

hello_nextflow lesson uses deprecated implicit variable and channel factory #336

Closed
ggrimes opened this issue May 21, 2024 · 0 comments · Fixed by #342
Closed

hello_nextflow lesson uses deprecated implicit variable and channel factory #336

ggrimes opened this issue May 21, 2024 · 0 comments · Fixed by #342
Assignees
@mribeirodantas
Labels
training material

Comments

@ggrimes
Copy link

ggrimes commented May 21, 2024

In the lesson 03_hello_gatk part2

https://github.com/nextflow-io/training/blob/master/docs/hello_nextflow/03_hello_gatk.md

There is use of the implicit variable baseDir and the channel factory from that are both deprecated.

Would it better to use projectDir and fromPath
@mribeirodantas mribeirodantas self-assigned this May 21, 2024
mribeirodantas added a commit that referenced this issue May 27, 2024
@mribeirodantas
Merge pull request #337 from nextflow-io/update-baseDir
ffd71fa 
Fix #336 baseDir -> projectDir, from -> of
@mribeirodantas mribeirodantas mentioned this issue Jun 13, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mribeirodantas mribeirodantas

Labels
training material
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix awsbatch docs url nextflow-io/training
2 participants
@mribeirodantas @ggrimes