Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes Issue #14 in upstream. Takes server id as env var #28

Merged

Conversation

jonbartels
Copy link

I added support and documentation to take SERVER_ID as an environment variable and write it to appdata/server.id.

I tested with:

docker build -t connect_local --build-arg ARTIFACT=https://s3.amazonaws.com/downloads.mirthcorp.com/connect/4.1.1.b303/mirthconnect-4.1.1.b303-unix.tar.gz  .
docker run -e SERVER_ID='UwU-pwease-accept-my-peeawr' -p 8443:8443 connect_local  #check server.id file and log in to MC and see the server ID I set        
docker run -p 8443:8443 connect_local #see the normal autogenerated UUID as server ID        
docker run -e SERVER_ID='' -p 8443:8443 connect_local  #ensure blank is handled and server ID is autogenerated

image

@jonbartels
Copy link
Author

@cturczynskyj one of my devops guys here at Teladoc (Platinum customer, BTW) asked about this EXACT issue. This fixes #14 which you had tagged as triaged. Can I, or my devops goons, provide any specific help to get this PR accepted?

@pladesma pladesma changed the base branch from master to pr28-server-id March 3, 2023 18:39
@pladesma pladesma merged commit 138d249 into nextgenhealthcare:pr28-server-id Mar 3, 2023
@pladesma
Copy link
Collaborator

pladesma commented Mar 3, 2023

I've merged the PR to a branch so we can do some internal testing. We should have the code merged to master before the upcoming MC 4.3.0 release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants