collection: fixed operator constants [closes #145]

nextras · Dec 14, 2015 · 50276eb · 50276eb
1 parent 8f47862
commit 50276eb
Show file tree

Hide file tree

Showing 2 changed files with 18 additions and 3 deletions.
diff --git a/src/Collection/Helpers/ConditionParserHelper.php b/src/Collection/Helpers/ConditionParserHelper.php
@@ -17,9 +17,9 @@ class ConditionParserHelper
 	const OPERATOR_EQUAL = '=';
 	const OPERATOR_NOT_EQUAL = '!=';
 	const OPERATOR_GREATER = '>';
-	const OPERATOR_EQUAL_OR_GREATER = '=>';
+	const OPERATOR_EQUAL_OR_GREATER = '>=';
 	const OPERATOR_SMALLER = '<';
-	const OPERATOR_EQUAL_OR_SMALLER = '=<';
+	const OPERATOR_EQUAL_OR_SMALLER = '<=';
 
 
 	public static function parseCondition($condition)

diff --git a/tests/cases/unit/Collection/ArrayCollectionTest.phpt b/tests/cases/unit/Collection/ArrayCollectionTest.phpt
@@ -142,6 +142,22 @@ class ArrayCollectionTest extends TestCase
 	}
 
 
+	public function testOperators()
+	{
+		$books = new ArrayCollection([
+			$this->e(Book::class, ['title' => '1']),
+			$this->e(Book::class, ['title' => '2']),
+			$this->e(Book::class, ['title' => '3']),
+			$this->e(Book::class, ['title' => '4']),
+		], $this->orm->books);
+
+		Assert::equal(2, $books->findBy(['title>=' => 3])->count());
+		Assert::equal(3, $books->findBy(['title<=' => 3])->count());
+		Assert::equal(1, $books->findBy(['title>' => 3])->count());
+		Assert::equal(2, $books->findBy(['title<' => 3])->count());
+	}
+
+
 	private function createCollection()
 	{
 		$authors = [
@@ -159,7 +175,6 @@ class ArrayCollectionTest extends TestCase
 
 		return [new ArrayCollection($authors, $this->orm->authors), $authors, $books];
 	}
-
 }