entity: virtual properties are never stored in implicit entity data (…

…BC break!)
nextras · Aug 27, 2017 · 987ca13 · 987ca13
1 parent 54b61f5
commit 987ca13
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 9 deletions.
diff --git a/src/Entity/AbstractEntity.php b/src/Entity/AbstractEntity.php
@@ -379,7 +379,7 @@ private function setterPrimaryProxy($value, PropertyMetadata $metadata)
 		foreach ($keys as $key) {
 			$this->setRawValue($key, array_shift($value));
 		}
-		return IEntity::SKIP_SET_VALUE;
+		return null;
 	}
 
 
@@ -417,7 +417,7 @@ private function internalSetValue(PropertyMetadata $metadata, string $name, $val
 
 		if ($metadata->hasSetter) {
 			$value = call_user_func([$this, $metadata->hasSetter], $value, $metadata);
-			if ($value === IEntity::SKIP_SET_VALUE) {
+			if ($metadata->isVirtual) {
 				$this->modified[$name] = true;
 				return;
 			}

diff --git a/src/Entity/IEntity.php b/src/Entity/IEntity.php
@@ -14,13 +14,6 @@
 
 interface IEntity
 {
-	/**
-	 * @const
-	 * Skips setting return value form setter.
-	 */
-	const SKIP_SET_VALUE = "\0";
-
-
 	public function getRepository(): IRepository;