Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(http): use multiple inheritance for http wrappers #124

Merged
merged 35 commits into from
Aug 11, 2022
Merged

refactor(http): use multiple inheritance for http wrappers #124

merged 35 commits into from
Aug 11, 2022

Conversation

ooliver1
Copy link
Member

This moves all HTTP wrappers to separate files so editors can handle them.

Each wrapper container subclasses BaseHTTPClient so the types of self._request and other attributes are known.
BaseHTTPClient is subclassed last from HTTPClient for a consistent mro order that python likes - overwrites the wrapper containers which are also subclasses.

@ooliver1
refactor(http): move http to a module
d1c813a
@ooliver1
refactor(http): move http methods to base client
517d64f
@ooliver1
refactor(http): move application command wrappers
349fdd2
@ooliver1
refactor(http): move audit log wrappers
4ce0310
@ooliver1
refactor(http): move channel http wrappers
5088862
@ooliver1
refactor(http): move emoji http wrappers
c03d923
@ooliver1
refactor(http): move guild http wrappers
13a6c11
@ooliver1
style(http): format client
d8aee4c
@ooliver1
refactor(http): move scheduled event http wrappers
46d6f48
@ooliver1
refactor(http): move guild template http wrappers
87ae63d
@ooliver1
refactor(http): move invite http wrappers
0ad631a
@ooliver1
fix(http): actually import invite wrappers
5c26967
@ooliver1
chore: remove whatever this is
d528464
@ooliver1
refactor(http): move stage instance http wrappers
4be11e0
@ooliver1
refactor(http): move sticker http wrappers
ec2da2e
@ooliver1
refactor(http): move user http wrappers
d9a8c68
@ooliver1
refactor(http): move voice http wrappers
26ce77f
@ooliver1
refactor(http): move webhook http wrappers
7b3b258
@ooliver1
refactor(http): move gateway http wrappers
653bdf1
@ooliver1
refactor(http): move oauth2 http wrappers
f79a0ee
@ooliver1 ooliver1 added scope/nextcore.http Any changes to the nextcore.http namespace type/refactor Refactor code labels Jul 20, 2022
@ooliver1 ooliver1 requested a review from TAG-Epic July 20, 2022 15:55
TAG-Epic
TAG-Epic requested changes Jul 20, 2022
View reviewed changes
Copy link
Member

@TAG-Epic TAG-Epic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note that ive not looked at the wrappers as i assume all of them is copy pasted

nextcore/http/client/__init__.py Show resolved Hide resolved
nextcore/http/client/base_client.py Outdated Show resolved Hide resolved
nextcore/http/client/wrappers/__init__.py Show resolved Hide resolved
@ooliver1 ooliver1 force-pushed the ooliver1/refactor/http-client-multi-inheritance branch from 002c23c to 0c30b2e Compare July 20, 2022 16:50
TAG-Epic
TAG-Epic requested changes Jul 26, 2022
View reviewed changes
nextcore/http/client/base_client.py Outdated Show resolved Hide resolved
nextcore/http/client/base_client.py Outdated Show resolved Hide resolved
nextcore/http/client/base_client.py Outdated Show resolved Hide resolved
nextcore/http/client/base_client.py Outdated Show resolved Hide resolved
nextcore/http/client/base_client.py Outdated Show resolved Hide resolved
nextcore/http/client/base_client.py Outdated Show resolved Hide resolved
nextcore/http/client/base_client.py Outdated Show resolved Hide resolved
nextcore/http/client/wrappers/application_commands.py Outdated Show resolved Hide resolved
TAG-Epic
TAG-Epic requested changes Jul 26, 2022
View reviewed changes
docs/http.rst Show resolved Hide resolved
nextcore/http/client/wrappers/__init__.py Show resolved Hide resolved
@ooliver1 ooliver1 requested review from TAG-Epic and alentoghostflame and removed request for TAG-Epic and alentoghostflame July 26, 2022 11:45
TAG-Epic
TAG-Epic requested changes Jul 26, 2022
View reviewed changes
Copy link
Member

@TAG-Epic TAG-Epic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can ShardManager & Shard be changed to require GatewayHTTPWrappers instead of HTTPClient?

This was referenced Aug 7, 2022
Open
Merged
@ooliver1 ooliver1 force-pushed the ooliver1/refactor/http-client-multi-inheritance branch from 54b0f73 to e4900fa Compare August 9, 2022 13:38
@TAG-Epic TAG-Epic merged commit abd3a61 into master Aug 11, 2022
@TAG-Epic TAG-Epic deleted the ooliver1/refactor/http-client-multi-inheritance branch August 11, 2022 11:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TAG-Epic TAG-Epic TAG-Epic requested changes

Assignees
No one assigned
Labels
scope/nextcore.http Any changes to the nextcore.http namespace type/refactor Refactor code
Projects
Nextcore
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ooliver1 @TAG-Epic