Add wait parameter to rate limits #131
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… set to False, will error instead of waiting.
TAG-Epic
added
scope/nextcore.common
ooliver1
previously approved these changes
Aug 11, 2022
|
Going to add it to http wrappers first before merging |
… client & http client
|
There is a weird typing issue I really don't understand here https://github.com/nextsnake/nextcore/pull/131/files#diff-0a3a0c4c203f48e8a99ed5122db636a40e9c6e058afc284417f06fab5b274922R192 @ooliver1 do you have any ideas? |
ooliver1
suggested changes
Aug 12, 2022
Co-authored-by: Oliver Wilkes <oliverwilkes2006@icloud.com>
This was referenced Mar 16, 2023
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows you to skip waiting for rate limits and instead receive a error.
This does however have the drawback that you still need it to be async.
This does also not update http wrappers or _request, as that is waiting for @ooliver1's #124