New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[vcf] Replace write_VCF_translation
with treetime's write_vcf
#1356
Comments
write_vcf
function
A few observations after looking into this today: Minor errors in VCF genotype syntax
The genotype calls should be haploid (i.e. VCF files can't represent amino acid diversity The VCF spec doesn't seem to say that it's for nucleotide sequences only, but the 4.3 spec defines genotype ALTs as matching
It only writes one chromosome, and here we use different chromosomes for different genes. It wouldn't be hard to refactor it to accept multi-chromsome inputs. It's currently only used in 1 place in Augur and 1 place in TreeTime. Alternatively we could keep things so that But before embarking on this we need to decide whether we should be producing AA-VCFs. I know |
I may be completely and totally misremembering but I have some kind of vague memory of writing code that did output AAs in VCF format. This would very likely not at all have been official, but was my effort to produce a large number of gene translations in some kind of compressed format. If that's gone from the code now though, I can't really when where or when it disappeared... |
Yup! That's exactly the behaviour of |
write_vcf
functionwrite_VCF_translation
with treetime's write_vcf
augur.io.vcf
includeswrite_VCF_translation
which is used byaugur translate
. This functionality is better implemented (and now tested) in treetime so we should use that function instead.The text was updated successfully, but these errors were encountered: