Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

filter: Use intermediate columns for grouping #1070

Merged
merged 3 commits into from Oct 25, 2022
Merged

filter: Use intermediate columns for grouping #1070

merged 3 commits into from Oct 25, 2022

Commits on Oct 25, 2022

  1. Update formatting of comments

    @victorlin
    victorlin committed Oct 25, 2022
    Configuration menu
    Copy the full SHA
    c411e16 View commit details
    Browse the repository at this point in the history

  2. filter: Use intermediate columns for grouping 

    Previously:

1. year/month/day columns were created on the DataFrame used for grouping.
2. month was overwritten with (year, month).

This allowed year to be used for grouping, but also the same for day
which was an unintended side effect. Instead of adding columns with
those names, use names with a more distinct prefix that can be safely
discarded before grouping happens.
    @victorlin
    victorlin committed Oct 25, 2022
    Configuration menu
    Copy the full SHA
    3dda0de View commit details
    Browse the repository at this point in the history

  3. Update changelog

    @victorlin
    victorlin committed Oct 25, 2022
    Configuration menu
    Copy the full SHA
    7eacd26 View commit details
    Browse the repository at this point in the history