Improve usage of setup-miniconda #1126
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The option to use mamba-version in this action is still marked as experimental and has shown to be problematic with transient failures. As of Dec 2022, the equivalent conda-libmamba-solver is no longer marked as experimental¹ so hopefully it is more reliable. ¹ https://www.anaconda.com/blog/conda-is-fast-now
Based on the input description in action.yml¹, the default value is "flexible", and "true" is just an alias to "flexible". ¹ https://github.com/conda-incubator/setup-miniconda/blob/7e642bb2e4ca56ff706818a0febf72bb226d348d/action.yml#L173-L186
Use one install command for all dependencies, and specify the channels there since they don't need to be searched for conda-libmamba-solver.
|
Noting that a quick comparison of run times between jobs in this old CI workflow and the jobs triggered by this PR shows that the previous total time of |
joverlee521
added a commit
to nextstrain/forecasts-ncov
that referenced
this pull request
Jan 12, 2023
Based on changes made in nextstrain/augur#1126.
3 tasks
This was referenced Jan 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of proposed changes
See commit messages.
Related issue(s)
Fixes #1125
Testing
Checklist
Add a message in CHANGES.md summarizing the changes in this PR that are end user focused. Keep headers and formatting consistent with the rest of the file.N/A, dev change