Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add dev status update to changelog #1166

Merged
merged 1 commit into from
Mar 8, 2023
Merged

Conversation

victorlin
Copy link
Member

Follow-up to #1160.

I think this is worth adding in the changelog because it is visible on PyPI:

image

@victorlin victorlin changed the title Update changelog Add dev status update to changelog Feb 24, 2023
@victorlin victorlin force-pushed the victorlin/update-dev-status branch from ea3fe1b to 8e61017 Compare March 8, 2023 20:28
CHANGES.md Outdated
@@ -7,8 +7,10 @@
* translate: Fix error handling when features cannot be read from reference sequence file. [#1168][] (@victorlin)
* translate: Remove an unnecessary check which allowed for inaccurate error messages to be shown. [#1169][] (@victorlin)
* frequencies: Previously, monthly pivot points calculated from the end of a month may have been shifted by 1-3 days. This is now fixed. [#1150][] (@victorlin)
* Update package metadata for PyPI. [#1160][] (@corneliusroemer)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was surprised that this changelog entry doesn't say more specifically what changed. I think the utility of the changelog entry is pretty limited without that!

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reworded in force-push.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙏

@victorlin victorlin force-pushed the victorlin/update-dev-status branch from 8e61017 to bf99148 Compare March 8, 2023 22:46
@victorlin victorlin merged commit 3cf9671 into master Mar 8, 2023
@victorlin victorlin deleted the victorlin/update-dev-status branch March 8, 2023 23:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

2 participants