Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

filter: Restore automatic boolean conversion #1410

Merged
merged 10 commits into from Feb 12, 2024
Merged

filter: Restore automatic boolean conversion #1410

merged 10 commits into from Feb 12, 2024

Commits on Feb 9, 2024

  1. filter: Add test to show current behavior

    @joverlee521 @victorlin
    joverlee521 authored and victorlin committed Feb 9, 2024
    Copy the full SHA
    7d2b98c View commit details
    Browse the repository at this point in the history

  2. Make test file more concise 

    Use one comment to explain both the example file and command. This will
make the file more readable with multiple commands.
    @victorlin
    victorlin committed Feb 9, 2024
    Copy the full SHA
    8d8e3b8 View commit details
    Browse the repository at this point in the history

  3. Reword comment 

    Previous wording was wordy. Make it more concise.
    @victorlin
    victorlin committed Feb 9, 2024
    Copy the full SHA
    0cc4eff View commit details
    Browse the repository at this point in the history

  4. Add note on type conversion

    @victorlin
    victorlin committed Feb 9, 2024
    Copy the full SHA
    78859b1 View commit details
    Browse the repository at this point in the history

  5. Remove support for 'numeric' type to --query-columns 

    Automatic conversion is applied by default. Reserve the 'numeric' type
for automatic conversions and keep the accepted values to
--query-columns strict (for numeric, either 'int' or 'float').
    @victorlin
    victorlin committed Feb 9, 2024
    Copy the full SHA
    570f563 View commit details
    Browse the repository at this point in the history

  6. Restore automatic boolean conversion 

    Boolean conversion was not considered when automatic nullable numeric
conversion was applied¹, but it continued to work because augur filter
relied on pandas.read_csv's automatic type inference up until it was
disabled in favor of reading all columns as string².

A note to include boolean was added³ but removed inadvertently in
another big change⁴.

¹ b325b97: Try converting all columns to numerical type
² 9f9be3a: Read all metadata as string type
³ 725e1b4: Expand comment on numeric conversion
⁴ b0a0d11: Add --query-columns option
    @victorlin
    victorlin committed Feb 9, 2024
    Copy the full SHA
    637b7be View commit details
    Browse the repository at this point in the history

  7. Add more boolean query tests

    @victorlin
    victorlin committed Feb 9, 2024
    Copy the full SHA
    df97f72 View commit details
    Browse the repository at this point in the history

  8. Support nullable boolean columns 

    This was not previously supported by pandas.read_csv's built-in type
inference, but it aligns with the existing support for nullable numeric
columns.
    @victorlin
    victorlin committed Feb 9, 2024
    Copy the full SHA
    bd35393 View commit details
    Browse the repository at this point in the history

  9. Support bool type in --query-columns

    @victorlin
    victorlin committed Feb 9, 2024
    Copy the full SHA
    423b3b6 View commit details
    Browse the repository at this point in the history

  10. Update changelog

    @victorlin
    victorlin committed Feb 9, 2024
    Copy the full SHA
    d44506d View commit details
    Browse the repository at this point in the history